Skip to content

Commit

Permalink
removing secrets/environment variables that are passed in as argument…
Browse files Browse the repository at this point in the history
…s into make build command as these are passed to the container from the ECS task definitions and should not be baked in during build as results in a security vulnerability ND-570 (#849)
  • Loading branch information
asifamirat00 authored Dec 12, 2024
1 parent 9254e43 commit 826e03f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ authenticate-docker: ## Authenticate docker script

.PHONY: build
build: ## docker build image
docker build --platform linux/amd64 -t admin . --build-arg RACK_ENV --build-arg DB_HOST --build-arg DB_USER --build-arg DB_PASS --build-arg SECRET_KEY_BASE --build-arg DB_NAME --build-arg BUNDLE_WITHOUT
docker build --platform linux/amd64 -t admin . --build-arg RACK_ENV --build-arg BUNDLE_WITHOUT

.PHONY: build-dev
build-dev: ## build-dev image
Expand Down

0 comments on commit 826e03f

Please sign in to comment.