Skip to content

Commit

Permalink
Required to preped make targets with $(MAKE)
Browse files Browse the repository at this point in the history
Since rearranging the Makefile for ease of devloper use and understanding.
ND-159
  • Loading branch information
Stephen.James committed Mar 11, 2024
1 parent 7524e32 commit 3fb8b83
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ yarn-debug.log*

.vscode
coverage
.idea

/.env
/.env.*
Expand Down
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ start-db: ## start database

.PHONY: db-setup
db-setup: ## setup database
start-db
$(MAKE) start-db
$(DOCKER_COMPOSE) run --rm app ./bin/rails db:drop db:create db:schema:load

.PHONY: serve
serve: ## Start application
stop
start-db
$(MAKE) stop
$(MAKE) start-db
$(DOCKER_COMPOSE) up app

# TODO - this is potentially not needed, but we should check by running tests before removing
Expand Down Expand Up @@ -90,8 +90,8 @@ push: ## push image to ECR

.PHONY: publish
publish: ## run build and push targets
build
push
$(MAKE) build
$(MAKE) push

.PHONY: lint
lint: ## lint
Expand Down

0 comments on commit 3fb8b83

Please sign in to comment.