pfs-211 added in ff for admin #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicholassully
force-pushed
the
pfs-211-added-in-feature-flag-for-admin
branch
4 times, most recently
from
045e2d5 to
f6afcb9
Compare
Nicholassully
force-pushed
the
pfs-211-added-in-feature-flag-for-admin
branch
from
f6afcb9 to
848e37a
Compare
Nicholassully
force-pushed
the
pfs-211-added-in-feature-flag-for-admin
branch
2 times, most recently
from
e30772d to
16c6554
Compare
Nicholassully
force-pushed
the
pfs-211-added-in-feature-flag-for-admin
branch
from
16c6554 to
ba93bc6
Compare
denialanderror
requested changes
Jan 23, 2025
yarn.lock
Outdated
| @@ -1429,10 +1429,9 @@ onetime@^5.1.0: | |||
| dependencies: | |||
| mimic-fn "^2.1.0" | |||
|
|
|||
| "opg-sirius-header@ministryofjustice/opg-sirius-header#semver:v0.26.0": | |||
| "opg-sirius-header@ministryofjustice/opg-sirius-header#semver:v0.27.0-pfs-211-feature-flag-added-for-payments-admin.4": | |||
There was a problem hiding this comment.
I think you'll need to run yarn install again as this is still pointing at the PR image.
internal/server/env_vars.go
Outdated
| DefaultPaTeam: defaultPaTeamId, | ||
| DefaultProTeam: defaultProTeamId, | ||
| Features: strings.Split(getEnv("FEATURES", ""), ","), | ||
| FinanceAdminLink: getEnv("FINANCE_ADMIN_LINK", "1"), |
There was a problem hiding this comment.
I think it would be better to default this to toggled off, otherwise if the flag is not set to off in prod for some reason, it will be defaulted to on.
…inance admin link
Nicholassully
force-pushed
the
pfs-211-added-in-feature-flag-for-admin
branch
from
a867f5f to
645a465
Compare
denialanderror
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.