Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to pipenv #30

Merged
merged 3 commits into from
Oct 18, 2024
Merged

switch to pipenv #30

merged 3 commits into from
Oct 18, 2024

Conversation

abachleda-baca
Copy link
Contributor

@abachleda-baca abachleda-baca commented Oct 18, 2024 •
edited
Loading

👀 Purpose

  • Set up Pipenv

♻️ What's Changed

  • Replaced requirements.txt with Pipfile and Pipfile.lock
  • Updated Dockerfile to use pipenv
  • Updated gha workflows

📝 Notes

✅ Things to Check (Optional)

  • I have run all unit tests, and they pass.
  • I have ensured my code follows the project's coding standards.
  • I have checked that all new dependencies are up to date and necessary.

@abachleda-baca abachleda-baca requested a review from a team as a code owner October 18, 2024 08:24
andyrogers1973
andyrogers1973 approved these changes Oct 18, 2024
View reviewed changes
Copy link

@andyrogers1973 andyrogers1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@abachleda-baca abachleda-baca merged commit 5c242b9 into main Oct 18, 2024
15 checks passed
@abachleda-baca abachleda-baca deleted the pipenv_update branch October 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyrogers1973 andyrogers1973 andyrogers1973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
⚙️ Operations Engineering
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abachleda-baca @andyrogers1973