Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubeconfig update local copy #279

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Kubeconfig update local copy #279

merged 3 commits into from
Jul 16, 2024

Conversation

juddin927
Copy link
Contributor

No description provided.

juddin927 and others added 3 commits July 3, 2024 16:38
@juddin927
tweaked makefile to copy and merge kubeconfig from tooling conatiner …
0db5229 
…to local kubeconfig
Write container kube config to mounted project dir
1373ae6 
Added to .gitignore as we do not want to commit this file
Reverse order of config files prior to flattening.
994eb4c 
Also reference kube config in project directory.
@juddin927 juddin927 requested a review from a team as a code owner July 4, 2024 09:29
@juddin927 juddin927 requested review from tommoj, jamesgreen-moj and laurentb4 and removed request for a team July 4, 2024 09:29
sb21460
sb21460 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@sb21460 sb21460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sb21460
Copy link
Contributor

sb21460 commented Jul 16, 2024

LGTM

@sb21460 sb21460 merged commit f8a9644 into main Jul 16, 2024
4 of 5 checks passed
@sb21460 sb21460 deleted the kubeconfig-update-local-copy branch July 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb21460 sb21460 sb21460 approved these changes

@tommoj tommoj Awaiting requested review from tommoj tommoj is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@jamesgreen-moj jamesgreen-moj Awaiting requested review from jamesgreen-moj jamesgreen-moj is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@laurentb4 laurentb4 Awaiting requested review from laurentb4 laurentb4 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juddin927 @sb21460