generated from ministryofjustice/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended alerting #254
Merged
Merged
Extended alerting #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added alert rules for pre-prod and development * Added new routes for critical & non critical alerts for both development and pre-prod * Added new recievers with new slack webhooks for target environment * Updated deploy script, to pass in new slackweb hooks (cherry picked from commit a0a21c9)
* Added missing key values in values.yaml * combine channels into one for both preprod, dev & critical non critcal (cherry picked from commit 5050b30)
* combines ssm value into one parameter to avoid confusion when updating web hook in future (cherry picked from commit 24cb083)
(cherry picked from commit 01d273e)
Updated matacher on alerting to match critical alerts
jamesgreen-moj
requested review from
Gary-H9,
staff-infrastructure-moj and
mitchdawson1982
and removed request for
a team
February 8, 2024 16:39
jamesgreen-moj
temporarily deployed
to
development
February 8, 2024 16:39 — with
GitHub Actions
Inactive
jamesgreen-moj
had a problem deploying
to
pre-production
February 8, 2024 16:40 — with
GitHub Actions
Failure
juddin927
reviewed
Feb 8, 2024
k8s-helm-charts/cns-team-monitoring/templates/dns-dhcp-alert-rules-development.yaml
Outdated
Show resolved
Hide resolved
juddin927
reviewed
Feb 8, 2024
k8s-helm-charts/cns-team-monitoring/templates/dns-dhcp-alert-rules-development.yaml
Outdated
Show resolved
Hide resolved
jamesgreen-moj
temporarily deployed
to
development
February 8, 2024 16:48 — with
GitHub Actions
Inactive
jamesgreen-moj
had a problem deploying
to
pre-production
February 8, 2024 16:49 — with
GitHub Actions
Failure
juddin927
reviewed
Feb 8, 2024
chart: {{ .Chart.Name }} | ||
heritage: Helm | ||
release: {{ .Release.Name }} | ||
name: {{ .Release.Name }}.dns-dhcp.rules-pre-production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets name this as {{ .Release.Name }}.dns-dhcp-pre-production.rules
juddin927
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended alerts to pre-prod
Added in missing secret value