Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended alerting #254

Merged
merged 10 commits into from
Feb 9, 2024
Merged

Extended alerting #254

merged 10 commits into from
Feb 9, 2024

Conversation

jamesgreen-moj
Copy link
Contributor

Extended alerts to pre-prod
Added in missing secret value

* Added alert rules for pre-prod and development
* Added new routes for critical & non critical alerts for both
  development and pre-prod
* Added new recievers with new slack webhooks for target environment
* Updated deploy script, to pass in new slackweb hooks

(cherry picked from commit a0a21c9)
* Added missing key values in values.yaml
* combine channels into one for both preprod, dev & critical non critcal

(cherry picked from commit 5050b30)
* combines ssm value into one parameter to avoid confusion when updating
  web hook in future

(cherry picked from commit 24cb083)
(cherry picked from commit 01d273e)
Updated matacher on alerting to match critical alerts
chart: {{ .Chart.Name }}
heritage: Helm
release: {{ .Release.Name }}
name: {{ .Release.Name }}.dns-dhcp.rules-pre-production
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets name this as {{ .Release.Name }}.dns-dhcp-pre-production.rules

Copy link
Contributor

@juddin927 juddin927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juddin927 juddin927 merged commit 53a59ed into main Feb 9, 2024
3 of 5 checks passed
@juddin927 juddin927 deleted the extended-alerting branch February 9, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants