Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAF bug fix #341

Merged
merged 4 commits into from
Nov 14, 2024
Merged

WAF bug fix #341

merged 4 commits into from
Nov 14, 2024

Conversation

laurentb4
Copy link
Contributor

  • Upgraded terraform version to one with the fix
  • Removed lifecycle block from WAF resource
  • Unpinned AWS provider version to be compatible with the bastion repo, and to facilitate WAF tag apply fix

@laurentb4 laurentb4 requested a review from a team as a code owner November 14, 2024 07:58
@laurentb4 laurentb4 requested review from dms1981, kyphutruong and mitchdawson1982 and removed request for a team November 14, 2024 07:58
sb21460
sb21460 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@sb21460 sb21460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentb4 laurentb4 merged commit b1e98f8 into main Nov 14, 2024
4 checks passed
@laurentb4 laurentb4 deleted the ND-85 branch November 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb21460 sb21460 sb21460 approved these changes

@dms1981 dms1981 Awaiting requested review from dms1981 dms1981 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@kyphutruong kyphutruong Awaiting requested review from kyphutruong kyphutruong is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@mitchdawson1982 mitchdawson1982 Awaiting requested review from mitchdawson1982 mitchdawson1982 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
network-access-control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentb4 @sb21460