Refactoring SSM parameters #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentb4
requested review from
AafAnsari,
kyphutruong and
mitchdawson1982
and removed request for
a team
laurentb4
had a problem deploying
to
development
GitHub Actions
Failure
jamesgreen-moj
approved these changes
Oct 22, 2024
variables.tf
Outdated
| #TODO check the correct value for this email | ||
| variable "owner_email" { | ||
| type = string | ||
| default = "nac@digital.justice.gov.uk" | ||
| default = "[email protected]" |
There was a problem hiding this comment.
This email does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the way SSM parameters are pulled into the workspace.
Removed the get-ssm-parameter.sh script and replaced it with terraform data source which are used in a locals block.
Archived the old scripts.
Removed TF_VARS from buildspec.yml
It should still work the same as before - i.e.
Pull branch locally and test before approving please. When testing - run a plan on main and take note of the number of changes. When you run the plan on this branch the numbers should be the same - if not let me know.