Added service name to the secrets description #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 30, 2024 12:17
Descriptons for the the secrets should be added as a blank field is displayed otherwise. ND-398
When other secrets have their descriptions added this will be necessary. Also some secrets name/path have unhelpful legacy information in them which is misleading and the combination of a good description and AWS resources tag will help greatly in maiking the use clearer. ND-398
smjmoj
requested review from
ASTRobinson,
moontune and
jamesgreen-moj
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other secrets have their descriptions added this will be necessary.
Also some secrets name/path have unhelpful legacy information in them which is misleading and the combination of a good description and AWS resources tag will help greatly in making the use clearer.
ND-398