Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resource to block public access to firehose bucket #278

Closed
wants to merge 2 commits into from

Conversation

laurentb4
Copy link
Contributor

Added resource to block public access to firehose bucket

@laurentb4 laurentb4 requested a review from a team as a code owner May 15, 2024 14:41
@laurentb4 laurentb4 requested review from Gary-H9, ASTRobinson and mTouhid and removed request for a team May 15, 2024 14:41
Copy link
Contributor

@asifamirat00 asifamirat00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juddin927
Copy link
Contributor

I think the bucket policy is blocking all public access on account level, Is there any benefit of applying an explicit block?

@laurentb4
Copy link
Contributor Author

Not needed due to default settings on S3 bucket

@smjmoj smjmoj deleted the ND-235-block-public-access branch June 27, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants