Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added OCSP destination IP for PRS to be routed via NAT gateway on the… #276

Merged
merged 1 commit into from
May 13, 2024
Merged

added OCSP destination IP for PRS to be routed via NAT gateway on the… #276

merged 1 commit into from
May 13, 2024

Conversation

juddin927
Copy link
Contributor

@juddin927 juddin927 commented May 3, 2024 •
edited
Loading

  • NACs Public route table updated to reflect PRS OCSP endpoint to be routed via NAT

DEV Only at this moment therefore do not merge this PR until we get the IPs for Production OCSP Endpoint too

@juddin927 juddin927 requested a review from a team as a code owner May 3, 2024 11:15
@juddin927 juddin927 requested review from dms1981, moontune and jamesgreen-moj and removed request for a team May 3, 2024 11:15
smjmoj
smjmoj approved these changes May 13, 2024
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juddin927 juddin927 merged commit dd553c4 into main May 13, 2024
4 of 5 checks passed
@juddin927 juddin927 deleted the ocsp-prs branch May 13, 2024 12:57
jamesgreen-moj
jamesgreen-moj reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@jamesgreen-moj jamesgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to use a data object to pull in the parameter rather than adding to the buildspec and make file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgreen-moj jamesgreen-moj jamesgreen-moj left review comments

@smjmoj smjmoj smjmoj approved these changes

@dms1981 dms1981 Awaiting requested review from dms1981 dms1981 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@moontune moontune Awaiting requested review from moontune moontune is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
network-access-control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juddin927 @smjmoj @jamesgreen-moj