Nd-105 implement NACS admin lockdown to known IPS #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgreen-moj
had a problem deploying
to
development
GitHub Actions
Failure
jamesgreen-moj
temporarily deployed
to
development
GitHub Actions
Inactive
jamesgreen-moj
temporarily deployed
to
development
GitHub Actions
Inactive
jamesgreen-moj
had a problem deploying
to
development
GitHub Actions
Failure
jamesgreen-moj
had a problem deploying
to
development
GitHub Actions
Failure
jamesgreen-moj
requested review from
staff-infrastructure-moj,
mitchdawson1982 and
asifamirat00
and removed request for
a team
juddin927
reviewed
Apr 23, 2024
modules/admin/locals.tf
Outdated
| authorised_ips = [ | ||
| "35.176.93.186/32", | ||
| "194.33.193.0/25", | ||
| "194.33.196.0/25", |
There was a problem hiding this comment.
to be safe you can use 194.33.192.0/18 its owned by MOJ, You can replace all 194.33 ranges by that.
|
approved |
jamesgreen-moj
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock down NACS admin to known IPS only