Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xsiam firehose #259

Merged
merged 13 commits into from
Feb 2, 2024
Merged

Xsiam firehose #259

merged 13 commits into from
Feb 2, 2024

Conversation

jamesgreen-moj
Copy link
Contributor

  • added new xsiam firehose module
  • Added ability to pull secrets in via data block
  • Defined access_key & http_endpoint in secrets manager
  • This is a draft waiting on endpoint details

juddin927 and others added 5 commits January 31, 2024 13:44
@juddin927
firehose module for xsiam logs ingestion
e4cad02
@jamesgreen-moj
Added terraform force unlock
4011d31
@jamesgreen-moj
adjusted iam polcies, and module to main.tf
34462d3
@jamesgreen-moj
Added Cloudwatch error logging
15cecfb 
Added config so we can view Cloudwatch logging errors via cloudwatch
@jamesgreen-moj
updated module to use secrets manager via data
3ea4d70 
AWS secrets mananger now store the http endpoint and access_key for the
firehose http endpoint.
@juddin927 juddin927 marked this pull request as ready for review February 1, 2024 17:56
@juddin927 juddin927 requested a review from a team as a code owner February 1, 2024 17:56
@juddin927 juddin927 requested review from smjmoj, staff-infrastructure-moj and mitchdawson1982 and removed request for a team February 1, 2024 17:56
smjmoj
smjmoj reviewed Feb 2, 2024
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See queries.
Otherwise LGTM

modules/kinesis_firehose_xsiam/main.tf Outdated Show resolved Hide resolved
modules/kinesis_firehose_xsiam/log_group_subscription.tf Show resolved Hide resolved
@jamesgreen-moj jamesgreen-moj requested a review from smjmoj February 2, 2024 15:13
smjmoj
smjmoj approved these changes Feb 2, 2024
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juddin927 juddin927 merged commit c2ce7fa into main Feb 2, 2024
4 checks passed
@juddin927 juddin927 deleted the xsiam-firehose branch February 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smjmoj smjmoj smjmoj approved these changes

@staff-infrastructure-moj staff-infrastructure-moj Awaiting requested review from staff-infrastructure-moj staff-infrastructure-moj is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@mitchdawson1982 mitchdawson1982 Awaiting requested review from mitchdawson1982 mitchdawson1982 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
network-access-control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgreen-moj @smjmoj @juddin927