Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserving history from main while resetting HEAD #769

Merged
merged 1 commit into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/format-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2.6'
ruby-version: '3.2.2'

- name: Format code
env:
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.6
3.2.2
5 changes: 2 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:3.2.6-alpine3.19
FROM ruby:3.2.2-alpine3.16

ARG UID=1001
ARG GROUP=app
Expand All @@ -23,7 +23,6 @@ ARG BUILD_DEV

# required for certain linting tools that read files, such as erb-lint
ENV LANG='C.UTF-8' \
LC_ALL='C.UTF-8' \
RACK_ENV=${RACK_ENV} \
DB_HOST=${DB_HOST} \
DB_USER=${DB_USER} \
Expand All @@ -36,7 +35,7 @@ ENV LANG='C.UTF-8' \
CLOUDWATCH_LINK=${CLOUDWATCH_LINK}

RUN apk add --no-cache --virtual .build-deps build-base && \
apk add --no-cache gcompat nodejs yarn mysql-dev mysql-client bash make bind shadow freeradius
apk add --no-cache gcompat nodejs yarn mysql-dev mysql-client bash make bind shadow freeradius

RUN if [ "${BUILD_DEV}" = "true" ] ; then \
apk add --no-cache alpine-sdk ruby-dev; \
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ DEPENDENCIES
webmock

RUBY VERSION
ruby 3.2.6p234
ruby 3.2.2p53

BUNDLED WITH
2.4.19
2.3.3
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ services:
context: .
args:
UID: "${UID}"
BUNDLE_INSTALL_FLAGS: "${BUNDLE_INSTALL_FLAGS:- --jobs 5 --retry 5}"
BUNDLE_INSTALL_FLAGS: "${BUNDLE_INSTALL_FLAGS:- --jobs 20 --retry 5 --full-index}"
user: "${UID}:${UID}"
command: bash -c "rm -f tmp/pids/server.pid && bundle exec rails s -p 3000 -b '0.0.0.0'"
volumes:
Expand Down
12 changes: 3 additions & 9 deletions spec/use_cases/read_certificate_metadata_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,28 +33,22 @@
expected_serial = "261449075976929706890225671845538541127278523818"
expect(serial).to eq expected_serial
end

it "extracts the extensions of the certificate" do
extensions = use_case.call[:extensions]
expected_extensions = <<~EXTENSIONS
subjectKeyIdentifier:
\t46:53:FE:BC:50:C0:5D:02:B5:24:1B:BA:B3:B8:E2:89:87:85:40:08

authorityKeyIdentifier:
\t46:53:FE:BC:50:C0:5D:02:B5:24:1B:BA:B3:B8:E2:89:87:85:40:08
\tkeyid:46:53:FE:BC:50:C0:5D:02:B5:24:1B:BA:B3:B8:E2:89:87:85:40:08


basicConstraints: critical
\tCA:TRUE
EXTENSIONS

puts "Actual extensions (raw): #{extensions.inspect}"
puts "Expected extensions (raw): #{expected_extensions.strip.inspect}"

normalize = ->(str) { str.gsub(/\n+/, "\n").strip }
actual_extensions = normalize.call(extensions.force_encoding("UTF-8"))
expected_extensions = normalize.call(expected_extensions.force_encoding("UTF-8"))

expect(actual_extensions).to eq expected_extensions
expect(extensions).to eq expected_extensions.strip
end
end

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.