Feature/nd 570 remove secrets baked into admin container #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-container- Pulling in latest updates to main
…s into make build command as these are passed to the container from the ECS task definitions and should not be baked in during build as results in a security vulnerability ND-570
asifamirat00
requested review from
Gary-H9,
moontune and
sb21460
and removed request for
a team
…in-container- Pulling in latest updates to main
…in-container- Pulling in latest updates to main
…in-container- Pulling in latest updates to main
asifamirat00
deleted the
feature/ND-570-Remove-secrets-baked-into-admin-container-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed secrets/environment variables that are passed in as arguments into make build command as these are passed to the container from the ECS task definitions and should not be baked in during build as results in a security vulnerability ND-570. Tested the removal of vars/secrets passed as args from the make build command. Can build the container image locally when running 'make build' makefile command. The build completes successfully without failures and all tests pass