Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND-279 update readme and makefile on na cs admin #693

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

smjmoj
Copy link

@smjmoj smjmoj commented Apr 10, 2024

No description provided.

asifamirat00 and others added 6 commits April 4, 2024 10:44
Made them retrieve this projects values.
ND-279
for retrieving env values from AWS SSM paramterstore.
Needs refining.
ND-279
so that the new feature is clearer to understand it's purpose of pulling config for checking purposes; not for use with development or test.

Added files to gitignore.
ND-279
@smjmoj smjmoj requested a review from a team as a code owner April 10, 2024 09:01
@smjmoj smjmoj requested review from mitchdawson1982, juddin927 and sb21460 and removed request for a team April 10, 2024 09:01
@github-actions github-actions bot added documentation Improvements or additions to documentation network-access-control labels Apr 10, 2024
Copy link
Contributor

@juddin927 juddin927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smjmoj smjmoj merged commit 97f99ef into main Apr 10, 2024
4 checks passed
@smjmoj smjmoj deleted the ND-279-update-readme-and-makefile-on-na-cs-admin branch April 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation network-access-control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants