Excluding EntraID users and groups from deletion #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story Link: ministryofjustice/analytical-platform#4838
Currently the scim function fully reconciles Github membership to AWS Identity Center. However, if we want to progress to a transitional stage where authentication is possible both from Github and EntraID, the Github SCIM function needs to ignore groups and users synchronised from EntraID.
This PR adds logic to skip deletion of users with @justice.gov.uk addresses and groups prefixed with
entraid-aws-identitycenter-
which will be managed by an alternative Lambda function being developed here: https://github.com/ministryofjustice/moj-terraform-scim-entra-idTest run with
GITHUB_ORGANISATION=ministryofjustice GITHUB_TOKEN=XXXXXXXXX SSO_AWS_REGION=eu-west-2 SSO_EMAIL_SUFFIX='@digital.justice.gov.uk' SSO_IDENTITY_STORE_ID=XXXXX node index.js
Output snippet: