Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the requests import and adding missing IAM permssions #16

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

julialawrence
Copy link
Contributor

ministryofjustice/analytical-platform#4271

This PR adds workflow to run integration and unit tests on push to any branch as well ass adds terraform code for a module that does an end-to-end deployment of this lambda function, mirroring the approach here:
https://github.com/ministryofjustice/moj-terraform-scim-github

Fixes in this PR:

  • Adding describeuser permission
  • adding sso:listinstances permission
  • fixing the requests import statement to use the one packaged into the lambda runtime.

Note: Racoon still unhappy but will be fixed.

Copy link

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julialawrence julialawrence merged commit 19071fc into main Sep 9, 2024
20 of 23 checks passed
@julialawrence julialawrence deleted the feature/amend-iam-roles-and-imports branch September 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants