Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytical-platform-common to networking resources #8767

Merged

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Dec 14, 2024

A reference to the issue / Description of it

#8621

How does this PR fix the problem?

Completes part two of our new account setup. Does a little extra alphabetising.

How has this been tested?

Tested through CI pipeline

Deployment Plan / Instructions

Deploy through CI. Confirm RAM shares are in place following deployment

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner December 14, 2024 09:53
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments-networks/*.json files will affect the networking of MP AWS accounts, in particular which VPC/Subnet is being shared in to which environment. For more guidance consult the documentation.

@github-actions github-actions bot added onboarding Tasks to onboard teams testing labels Dec 14, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@richgreen-moj richgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richgreen-moj richgreen-moj added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 3b1b353 Dec 16, 2024
7 checks passed
@richgreen-moj richgreen-moj deleted the feature/8621-analytical-platform-common-account-2 branch December 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants