🌐 Add Platforms General shared VPC to Analytical Platform Ingestion

[jacobwoffenden]

A reference to the issue / Description of it

Is part of ministryofjustice/analytical-platform#5175

https://mojdt.slack.com/archives/C01A7QK5VM1/p1727263917973289

How does this PR fix the problem?

Adds analytical-platform-ingestion to what I think is the right places based on data-platform

How has this been tested?

It hasn't been tested

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No

Checklist (check x in [ ] of list items)

• I have performed a self-review of my own code
• All checks have passed
• I have made corresponding changes to the documentation
• Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

[github-actions]

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments-networks/*.json files will affect the networking of MP AWS accounts, in particular which VPC/Subnet is being shared in to which environment. For more guidance consult the documentation.

[github-actions]

Trivy Scan Success

Show Output

```hcl

---

Trivy will check the following folders:
terraform/environments/analytical-platform-ingestion

---

Running Trivy in terraform/environments/analytical-platform-ingestion
2024-09-25T19:36:04Z INFO [db] Need to update DB
2024-09-25T19:36:04Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-25T19:36:06Z INFO [vuln] Vulnerability scanning is enabled
2024-09-25T19:36:06Z INFO [misconfig] Misconfiguration scanning is enabled
2024-09-25T19:36:06Z INFO Need to update the built-in policies
2024-09-25T19:36:06Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-25T19:36:06Z INFO [secret] Secret scanning is enabled
2024-09-25T19:36:06Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-25T19:36:06Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-25T19:36:07Z INFO [terraform scanner] Scanning root module file_path="."
2024-09-25T19:36:07Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-09-25T19:36:07Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ram-ec2-retagging[0].data.aws_subnet.host" value="cty.NilVal"
2024-09-25T19:36:07Z INFO Number of language-specific files num=0
2024-09-25T19:36:07Z INFO Detected config files num=1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running Checkov in terraform/environments/analytical-platform-ingestion
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 5, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running tflint in terraform/environments/analytical-platform-ingestion
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output

*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running Trivy in terraform/environments/analytical-platform-ingestion
2024-09-25T19:36:04Z	INFO	[db] Need to update DB
2024-09-25T19:36:04Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-25T19:36:06Z	INFO	[vuln] Vulnerability scanning is enabled
2024-09-25T19:36:06Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-09-25T19:36:06Z	INFO	Need to update the built-in policies
2024-09-25T19:36:06Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-25T19:36:06Z	INFO	[secret] Secret scanning is enabled
2024-09-25T19:36:06Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-25T19:36:06Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-25T19:36:07Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-09-25T19:36:07Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="networking"
2024-09-25T19:36:07Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.ram-ec2-retagging[0].data.aws_subnet.host" value="cty.NilVal"
2024-09-25T19:36:07Z	INFO	Number of language-specific files	num=0
2024-09-25T19:36:07Z	INFO	Detected config files	num=1
trivy_exitcode=0