Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wardship: fix security hub issues #5465

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Wardship: fix security hub issues #5465

merged 10 commits into from
Mar 26, 2024

Conversation

matt-k1998
Copy link
Contributor

No description provided.

@matt-k1998 matt-k1998 requested review from a team as code owners March 25, 2024 11:20
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
        





      

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@matt-k1998 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    











      

  
    

      
        2 similar comments
      
    

  
    

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@matt-k1998 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    










    

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@matt-k1998 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          
  

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 11:46      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 14:50      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 15:37      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 15:49      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 16:08      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 16:22      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
            

    

      
    

    


      

          @matt-k1998
matt-k1998




        changed the title
Wardship: fix vpc endpoint

Wardship: fix security hub issues


      Mar 25, 2024

    

  



  

  

  
  

  
      @matt-k1998
  matt-k1998


            had a problem deploying
      to
        wardship-development



    March 25, 2024 16:25      — with 
GitHub Actions

                
    Failure


    










        

  
        





        

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 16:27      — with 
GitHub Actions

                
    Inactive


    










        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
          

  

  
  

  
      @matt-k1998
  matt-k1998


            temporarily deployed
      to
        wardship-development



    March 25, 2024 16:56      — with 
GitHub Actions

                
    Inactive


    










        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
          

  

    
  

  


        
        @matt-k1998
  matt-k1998



        merged commit 0afa73f
      into

      
  
    main
  


    Mar 26, 2024

      

        14 checks passed
      


      

        
          
  
    
    

        
      

  







  

  
  

  
      @matt-k1998
  matt-k1998


    
    deleted the
    
      
        wardship-fix-vpc-endpoint
    
    branch

    March 26, 2024 10:09    
    




  


  
    
  
  

    
  matt-heery 

      pushed a commit
      that referenced
      this pull request

    
      Mar 28, 2024
    
    

      


  

    

      


  

      
        @matt-k1998
      
        @matt-heery
  





      

        
          Wardship: fix security hub issues (#5465)
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          1e6ca81
        
      

    

  




    

  




  


  
    
  
  

    
  SahidKhan89 

      pushed a commit
      that referenced
      this pull request

    
      Apr 2, 2024
    
    

      


  

    

      


  

      
        @matt-k1998
      
        @SahidKhan89
  





      

        
          Wardship: fix security hub issues (#5465)
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          095fb1a
        
      

    

  




    

  











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @matthewsearle01
  
    matthewsearle01



          
            
              
            
          
          matthewsearle01 approved these changes

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    environments-repository

  Used to exclude PRs from this repo in our Slack PR update








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @matt-k1998 
        
          @modernisation-platform-ci 
        
          @matthewsearle01