Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM457-2221: Allow providers to generate filtered lists #334

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patrick-laa
Copy link
Contributor

@patrick-laa patrick-laa commented Nov 26, 2024

Description of change

  • Providers can access the search endpoint
  • The search endpoint allows passing in multiple office codes
  • Searches can be sorted by UFN
  • Searches can be sorted by the date of the most recent state change (e.g. for submitted applications it's when they were submitted, not the date of the most recent caseworker assignment)
  • Caseworker app can no longer subscribe/unsubscribe (since it doesn't do that any more)

Link to relevant ticket

@patrick-laa patrick-laa marked this pull request as ready for review November 26, 2024 15:48
@patrick-laa patrick-laa requested a review from a team as a code owner November 26, 2024 15:48
@@ -1,6 +1,17 @@
module Submissions
class SearchService
SORTABLE_COLUMNS = %w[laa_reference firm_name client_name last_updated status_with_assignment risk_level service_name].freeze
SORTABLE_COLUMNS = %w[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't directly relate to this ticket but having these fields in the common gem will help us with the future query param validation ticket, agreed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think there's a question of how much search-related stuff goes into the common gem, because a lot of this stuff knows to a certain extent about the structure of the NSM and PA payloads, but trying to move e.g. view definitions into the gem is gonna send us loopy...

Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants