-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert malformed-yaml action to Python #255
Conversation
dcd37d4
to
b54e6b0
Compare
523c992
to
4a5a880
Compare
83a7711
to
ed13743
Compare
21217fc
to
dea9080
Compare
d7c2a19
to
52284cb
Compare
3ac9e83
to
d0bca10
Compare
e727828
to
3f2c7f0
Compare
f35fd65
to
c3c30d0
Compare
b91a349
to
a8c09c0
Compare
561a0d7
to
ec07694
Compare
457e071
to
cd0dde5
Compare
d91fb85
to
de35150
Compare
31fcef5
to
d1cd8fa
Compare
4bb46bf
to
146d077
Compare
😱 The following malformed YAML files and related errors were found: python-malformed-yaml/test/test_yaml_files/bad.yaml: python-malformed-yaml/test/test_yaml_files/bad.yml: 🥺 Please correct them and resubmit this PR. |
😱 The following malformed YAML files and related errors were found: python-malformed-yaml/test/test_yaml_files/bad.yaml: python-malformed-yaml/test/test_yaml_files/bad.yml: 🥺 Please correct them and resubmit this PR. |
😱 The following malformed YAML files and related errors were found: python-malformed-yaml/test/test_yaml_files/bad.yaml: python-malformed-yaml/test/test_yaml_files/bad.yml: 🥺 Please correct them and resubmit this PR. |
o test cases, similarly for format-code workflow
.github/workflows/format-code.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I'd like to, I don't think we can remove the code-formatter yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I think it will fail every time, as the code formatter notices malformed yamls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here: the code formatter notices the malformed YAML test files, can't fix them and fails the PR.
Co-authored-by: Jason Birchall <[email protected]>
Co-authored-by: Jason Birchall <[email protected]>
Co-authored-by: Jason Birchall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Just need to add format-code back in.
👀 Purpose
malformed-yaml
action from 💎 Ruby to 🐍 Python♻️ What's changed
python-malformed-yaml
using Python and Docker with the same functionality asmalformed-yaml
(if malformed YAML PR fails, changes requested, if good YAML PR OK, if no YAML changes PR OK).pytest
test formain.py
functions to detect malformed yaml files📝 Notes
requirements.txt
over Pipfile as there were problems running Pipfile in Docker container; can revisit-To Do
malformed-yaml
to replace Ruby version