Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform static analysis - Change to hardcoded path #198

Merged
merged 1 commit into from
May 17, 2023

Conversation

danlumb01
Copy link
Contributor

@danlumb01 danlumb01 commented May 17, 2023

I usually use act for working locally and testing Github Actions but I ran into an issue with the Terraform static analysis action because the entrypoint script referred to /github/workspace which isn't mapped through to the Docker container when using act. It couldn't find the files and dirs to scan.

I think the environment variable $GITHUB_WORKSPACE will always point through to the root of the repo in the Docker container when the action uses checkout, so I replaced it with this.

I tested this both running locally with act and when it runs for real in Github and both use cases seem to run correctly.

@danlumb01 danlumb01 requested a review from a team as a code owner May 17, 2023 13:47
@NickWalt01 NickWalt01 merged commit de29cc1 into main May 17, 2023
@NickWalt01 NickWalt01 deleted the change_hardcoded_dirs branch May 17, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants