Add separate config for tflint AWS plugin #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS plugin is currently not working if a local doesn't have a valid value if it's generate dynamically, there is no way to ignore this error, so separating the tflint config so the default is no plugins, and then the AWS plugin is defined in the tflint.aws.hcl file. This makes more sense anyway, and when the aws plugin is working again we can change actions to use that. I've checked the usage of this and currently only the modernisation platform is using the default, DSO uses the Azure one.
AntonyBishop
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tflint AWS plugin is currently not working if a local doesn't have a valid value if it's generate dynamically, there is no way to ignore this error, so separating the tflint config so the default is no plugins, and then the AWS plugin is defined in the tflint.aws.hcl file.
This makes more sense anyway, and when the aws plugin is working again we can change actions to use that. I've checked the usage of this and currently only the modernisation platform is using the default, DSO uses the Azure one.