Find moj data 69/glossary #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
murdo-moj
commented
Feb 26, 2024
•
murdo-moj
commented
- Added glossary view
- Added glossary service
- Added glossary template
- All of these will account for one parent node, or no parent node. (ie parent glossary term)
Open
MatMoore
previously approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Haven't checked the design itself but code changes look good.
Is there a figma for this page we should be comparing to?
I noticed we don't the sticky sidebar yet but I think it's worth doing that as a separate task as we need to make sure the layout is still responsive to different screen sizes.
MatMoore
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.