Fix low colour contrast and incorrect label markup #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This label was not associated with anything. If it's just regular text inside a `<button>` then a label is not required. > An <input> element with a type="button" declaration and a valid value attribute does not need a label associated with it. Doing so may actually interfere with how assistive technology parses the button input. The same applies for the <button> element. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
This is no longer being flagged by Wave, but there was still a low contrast between the search icon and its background. Using dark-blue gives us a 9.37:1 contrast ratio which is easier to perceive.
jemnery
approved these changes
Sep 26, 2024
jemnery
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markup is wrong because
<button>s should not have a separate<label>element - a button's label is its text content.This was originally flagged as a low contrast issue by WAVE, but when I corrected the markup it went away.
Although the existing colour meets the requirement for non-text elements at a ratio of 3.91:1, I thought I may as well switch it to the darker blue to make it clearer (9.37:1).
Before:
After:
