Quoted search fix #839
Quoted search fix #839
Conversation
There was a problem hiding this comment.
This looks good, but does it solve the bug on the ticket where "Common Platform" doesn't match anything?
https://find-moj-data.service.justice.gov.uk/search?query=%22Common+Platform%22&domain=
Even with exact matching I would expect this to return results, since the whole phrase is in the description of https://find-moj-data.service.justice.gov.uk/details/table/urn:li:dataset:(urn:li:dataPlatform:dbt,cadet.awsdatacatalog.common_platform_derived.cases_fct,PROD)
Regarding the matching behaviour of a quoted query, in this instance "Common Platform". My view is that I wouldn't expect this to match as it is a partial term. Common Platform does of course appear in a number of results, but when we are quoting the term we are saying that we are expecting a field with only this value, which isn't the case hence no results.
"Lookup table for Common Platform hearing result shortcodes." returns results because it is an exact match for an entire field (description), "Common Platform" isn't an exact match for any fields on the current dataset.
Adds a method to the search service to handle updated search behaviour in datahub. The recent datahub changes now mean that query strings containing either quotes, underscores or full stops are treated as exact matches.
This PR ensures that quoted queries are passed through to search unchanged whereas unquoted queries containing underscores are altered to remove them and replace them with spaces, to ensure a non-exact match search is performed.