ci: completely remove e2e test from ci #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including a test that depends on our datahub dev environment breaks in a bunch of subtle ways: - workflow_call triggered jobs can't access the secret, unless we explicitly pass it through from the parent workflows - dependabot can't access the secret, unless we copy the secret to dependabot secrets - pull requests from outside the org can't access the secret either either (a security measure to prevent exfiltrating secrets) the benefit of this test is already quite minimal so this has convinced me we don't need it in our CI pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including a test that depends on our datahub dev environment (and therefore needs a secret token) breaks in a bunch of subtle ways:
the benefit of this test is already quite minimal so this has convinced me we don't need it in our CI pipeline.