ci: skip end to end test in deploy pipeline #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusable-tests is run in two contexts: 1. on a pull request 2. as part of other workflows post-merge: `deploy-staged` and `deploy-dev-from-branch` The end to end testing step is working fine in scenario 1, but scenario 2 doesn't work because github cannot read the secret, when triggered with `workflow_call`. I don't think it's a good idea for `deploy-staged` to depend on these (potentially flaky) selenium tests, so I've bypassed it in this case.
murdo-moj
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reusable-tests is run in two contexts:
deploy-stagedanddeploy-dev-from-branchThe end to end testing step is working fine in scenario 1, but scenario 2 doesn't work because github cannot read the secret, when triggered with
workflow_call.I don't think it's a good idea for
deploy-stagedto depend on these (potentially flaky) selenium tests, so I've bypassed it in this case.