Add an end to end test that checks breadcrumbs #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
force-pushed
the
fmd-674-end-to-end-test
branch
from
6fa271c to
9f5b009
Compare
These can be used for end to end tests as well as Find MoJ data tests.
MatMoore
force-pushed
the
fmd-674-end-to-end-test
branch
from
9f5b009 to
3c75520
Compare
this requires github actions to be able to access the dev datahub instance.
MatMoore
force-pushed
the
fmd-674-end-to-end-test
branch
from
3c75520 to
cd473b4
Compare
MatMoore
changed the title
murdo-moj
reviewed
Sep 10, 2024
murdo-moj
previously approved these changes
Sep 10, 2024
MatMoore
force-pushed
the
fmd-674-end-to-end-test
branch
from
fdee59a to
c53fc74
Compare
murdo-moj
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't have any tests that run end to end using a real Datahub backend.
This PR adds one to test that breadcrumbs are rendered correctly. #674
Note: this introduces a CI dependency on the dev datahub instance, so it's possible that we could break that environment and block CI. However, CI is independent of the dev Find MoJ data instance.
As there is no test isolation, the test makes some assumptions about what data is populated: