Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor GitHub workflows for streamlined build and deploy process #712

Merged
merged 5 commits into from
Aug 22, 2024
Merged

chore: Refactor GitHub workflows for streamlined build and deploy process #712

merged 5 commits into from
Aug 22, 2024

Conversation

tom-webber
Copy link
Contributor

  • Add reusable build workflow that exports image artifact
  • Update deploy workflows to use new build and fetch artifact
  • Rename build-and-deploy to push-and-deploy
  • Remove unneeded deploy-to-dev workflow
  • Integrate Slack notifications for builds

@tom-webber
chore: Refactor GitHub workflows for streamlined build and deploy pro…
9d85362 
…cess

- Add reusable build workflow that exports image artifact
- Update deploy workflows to use new build and fetch artifact
- Rename build-and-deploy to push-and-deploy
- Remove unneeded deploy-to-dev workflow
- Integrate Slack notifications for builds
@tom-webber tom-webber requested a review from a team as a code owner August 22, 2024 14:10
MatMoore
MatMoore approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@MatMoore MatMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - this is a lot simpler than my previous approach.

I think the next step will be integrating deploy-prod into the main workflow, so that we are not building the image twice.

@MatMoore MatMoore mentioned this pull request Aug 22, 2024
Closed
@tom-webber tom-webber merged commit 2af2fd0 into main Aug 22, 2024
1 check passed
@tom-webber tom-webber deleted the fmj-590-artifact-workflow branch August 22, 2024 15:24
@tom-webber tom-webber linked an issue Aug 22, 2024 that may be closed by this pull request
Reorganise build-push-deploy workflow so build doesn't happen in environment #590
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatMoore MatMoore MatMoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganise build-push-deploy workflow so build doesn't happen in environment
2 participants
@tom-webber @MatMoore