Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename domain to subject area #679

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Aug 15, 2024

This removes the need for extra explanatory text on the home page.

I've also included a small change to the makefile and some documentation about reusing the code outside of MoJ, in anticipation of the meeting with Scottish Gov next week.

Resolves #621

compile_messages -> compilemessages
Add some notes about configuration for other orgs who may wish to reuse
this frontend. This is just a starting point for now.

As we speak more with the Scottish Government team we should get a
better understanding of the pain points and we can figure out a release
process that minimises breakages.
@MatMoore MatMoore marked this pull request as ready for review August 15, 2024 11:10
@MatMoore MatMoore requested a review from a team as a code owner August 15, 2024 11:10
@MatMoore MatMoore changed the title FMD-621 Rename domain to subject area Rename domain to subject area Aug 15, 2024
Copy link
Contributor

@hjribeiro-moj hjribeiro-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatMoore MatMoore merged commit 1a6393f into main Aug 15, 2024
7 of 8 checks passed
@MatMoore MatMoore deleted the fmj-621-rename-domain-to-subject-area branch August 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename domain to subject area
2 participants