Remove ingress rules for the old domain #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
commented
Aug 13, 2024
Now we have our domains set up, we don't need this ingress. These old URLs aren't fully working because EntraID will redirect the new URL after login. We should also use new domain for deployment notifications.
MatMoore
force-pushed
the
fmj-remove-old-prod-ingress
branch
from
d8870c8 to
d1394d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service is now on find-moj-data.service.justice.gov.uk, so everything should be using that.
The old domain is not functional anymore because the app is configured to use the new URL as the Oauth redirect_uri, meaning EntraID will redirect to the new origin but the app will expect cookies that were set on the old origin.