Update search form domain filters #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdawson1982
force-pushed
the
fmd-596-domain-filter-improvements
branch
from
9b61973 to
348fe44
Compare
mitchdawson1982
force-pushed
the
fmd-596-domain-filter-improvements
branch
from
348fe44 to
71f2e03
Compare
4 tasks
4 tasks
MatMoore
reviewed
Jul 29, 2024
mitchdawson1982
force-pushed
the
fmd-596-domain-filter-improvements
branch
from
d6cdd0a to
fc3074a
Compare
mitchdawson1982
force-pushed
the
fmd-596-domain-filter-improvements
branch
from
fc3074a to
0d051cb
Compare
MatMoore
reviewed
Jul 29, 2024
mitchdawson1982
force-pushed
the
fmd-596-domain-filter-improvements
branch
from
dcccde7 to
748858a
Compare
MatMoore
approved these changes
Jul 29, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilises the implementation from here to pull domains from the back end along with the count of entities tagged for display in the catalogue.
It is key to note that this implementation bypasses the existing
facetscode, and given that we are not currently usingsubdomainsand we have standalone fetchers for both tags and glossary we could consider removing the facets code altogether.get_list_domain_choicesfunction to return a list ofDomainobjects used for the domain filter options.