add _make_user_email_from_urn() to graphql helpers #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
reviewed
Jul 22, 2024
lib/datahub-client/data_platform_catalogue/client/graphql_helpers.py
Outdated
Show resolved
Hide resolved
…ers.py Co-authored-by: Mat <[email protected]>
MatMoore
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the owner not displaying bug. It has highlighted some deeper issues with our appraoch to ownership and usercreation.
But for a quick fix this will be ok for now so we have owners displaying in find-moj-data.
I have written up in some more dteail the issue in a new spike ticket added to our backlog, see #578
resolves #556