Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dc 2982 frontend changes #29

Merged
merged 34 commits into from
Jan 30, 2024
Merged

Dc 2982 frontend changes #29

merged 34 commits into from
Jan 30, 2024

Conversation

PriyaBasker23
Copy link
Contributor

@PriyaBasker23 PriyaBasker23 commented Jan 29, 2024 •
edited
Loading

Here is a checklist of design-related tasks to finalise on the prototype, aligning it with the specifications outlined in
https://www.figma.com/file/zTOVhHRnWfxRJqH6Gr8cIc/Catalogue-sketches?type=design&node-id=206-2398&mode=design&t=pEjdb6k2pwuuHuiw-0

completed the following task as per the following list

  • Ensure links have the govuk-link class.
  • Modify filters to include the desired options when initially presented to users (e.g., domain, data product).
  • Integrate pagination buttons at the bottom of the page.
  • Remove the horizontal rule between search results or eliminate lines from the summary list component.
  • Incorporate the details page (accessible by clicking on a result).
  • Apply Filter
  • Clear Filter
  • Remove Filters
  • Back buttons
  • Basic details page template

PriyaBasker23 and others added 27 commits January 19, 2024 10:15
@PriyaBasker23
Added basic styles
cf71dea
@PriyaBasker23
Add pagination template
42deb44
@PriyaBasker23
Added filter functionality
9506b20
@PriyaBasker23
Added functionality
e641006
@PriyaBasker23
updated filter html
fe600ac
@PriyaBasker23
search
1abc5ec
@PriyaBasker23
Filter functionality
25996e3
@PriyaBasker23
Merged with main
2af20b7
@PriyaBasker23
merged main
3fc93ca
@PriyaBasker23
updated to display real data
726512b
@PriyaBasker23
updated to display real data
f016920
@PriyaBasker23
merged with main
c990f83
@PriyaBasker23
fixed serach functionlity
88a2101
@PriyaBasker23
Added filter functionality
0fc5421
@PriyaBasker23
Added back button
1f3ed6f
@PriyaBasker23
Code refactor
5333f1b
@PriyaBasker23
Added detailed information
08919a9
@PriyaBasker23
Fixed error
75c8c93
@PriyaBasker23
updated the filter
5ad3996
@PriyaBasker23
integrated search
24b5edd
@PriyaBasker23
Completed remove filters
e7c9e99
@PriyaBasker23
Merge branch 'main' into dc-2982-frontend-changes
5249b8e
@PriyaBasker23
Added total results
f38fa68
@PriyaBasker23
changed sample data
b03a1a1
@github-actions
Commit changes made by code formatters
4414e8c
@PriyaBasker23
Updated query functionality
de4de80
@github-actions
Commit changes made by code formatters
52dcc5a
mitchdawson1982
mitchdawson1982 reviewed Jan 29, 2024
View reviewed changes
home/views.py Outdated Show resolved Hide resolved
mitchdawson1982
mitchdawson1982 reviewed Jan 29, 2024
View reviewed changes
home/urls.py Outdated Show resolved Hide resolved
mitchdawson1982
mitchdawson1982 reviewed Jan 29, 2024
View reviewed changes
home/views.py Outdated Show resolved Hide resolved
mitchdawson1982
mitchdawson1982 reviewed Jan 29, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
mitchdawson1982
mitchdawson1982 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PriyaBasker23 PriyaBasker23 merged commit 8d0b534 into main Jan 30, 2024
2 checks passed
@PriyaBasker23 PriyaBasker23 deleted the dc-2982-frontend-changes branch January 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdawson1982 mitchdawson1982 mitchdawson1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PriyaBasker23 @mitchdawson1982