Add a skip link for skipping filters in search #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
changed the title
tom-webber
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives keyboard users a quick way to skip the long sidebar with filters in.
The same pattern is already in use on GOV.UK finders:
Note that by default, the skip link component has
margin: inherit important!that causes the block to touch the following content, which is undesired in this case. To avoid this I've had to override it with an explicit margin-bottom rule.Also, I noticed that
$govuk-global-styles: true;includes a selector that overrides the skip link'stext-decoration: underline- I've added some extra css to add that back in.