Add sass via npm to compile stylesheets #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to pass variables to the design system, and will make updating easier. Use this to apply the design system styles globally, so that parts of the search result page can be rendered from markdown. If we want to restrict this more later, we can write more specific selectors that extend the GOV.UK styles, like this: https://github.com/ministryofjustice/cjs_scorecard_exploratory_analysis/blob/develop/cjs_test_app/scss/markdown-styles.scss I've set up the package.json so we manually run `npm run sass` when we want to recompile the sass. I figure this is probably good enough for us as we won't need to change stylesheets very often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to pass variables to the design system, and will make updating easier.
Use this to apply the design system styles globally, so that parts of the search result page can be rendered from markdown. If we want to restrict this more later, we can write more specific selectors that extend
the GOV.UK styles, like this:
https://github.com/ministryofjustice/cjs_scorecard_exploratory_analysis/blob/develop/cjs_test_app/scss/markdown-styles.scss
I've set up the package.json so we manually run
npm run sasswhen we want to recompile the sass. I figure this is probably good enough for us as we won't need to change stylesheets very often.