Show contact info and metadata on all details pages #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the dataset details match the data product details, and show description in its own paragraph, as per the figma design.
- Use correct elements for headings vs paragraphs - Reduce the normal margin spacing below the headings - the design here looks like a summary list, but with vertical spacing between title and value - Show names and emails together - Make emails clickable Since we do not have separate roles in datahub yet for point of contact vs IAO/data owner, just use the data owner email as the contact email. We will have another ticket soon to implement roles.
MatMoore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma: https://www.figma.com/file/zTOVhHRnWfxRJqH6Gr8cIc/Catalogue-sketches?type=design&node-id=203-2121&mode=design&t=fR5PQmBviZV30T0v-0
This PR extracts a partial for the contact information box shared by the data products details and dataset details. I've also adapted it to look more like the design, although this will need further work to define the different roles in datahub and make sure they are returned correctly to the frontend.
Currently we are only fetching the data owner from the datahub API, but we should also show a point of contact for access requests. I've defaulted to using the data owner for this as well, but we will need to do some more work to define the various roles in datahub.
I've added some of the metadata fields to the details page but not all of it is available in the backend yet. I will either raise separate tickets for this or do it in follow up PRs.
I'm not sure yet what this should look like when data is incomplete - for now I've just left stuff blank as we do on the data product details page.
Example data product with a data owner set
Example data product without a data owner set
Example dataset without a data owner set