-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use type mapping objects #1135
Conversation
2c666f6
to
7a0f08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks like an improvement from what we had before. Just a couple of minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
FindMoJDataEntityMapper
objects to translate from FMD to Datahub types and subtypesFindMoJDataEntityType
EnumEntityTypes
SearchClient.fmd_type_to_datahub_types_mapping
entity_type_filters
is now nicer.Note subtype "Metric" is not included in any of our searches now