fix: fetch lastIngested for charts, and correctly show data last updated #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the metadata last updated date was not showing for charts.
Previously we were inconsistently returning lastIngested as the timestamp for some (but not all) search results. If we do display a date here, it should be the data last updated, not the metadata last updated.
The last updated date was not displaying, as it referenced a custom property that does not exist in the pydantic model.
without this there is a bit too much space at the bottom of the card.
MatMoore
force-pushed
the
fetch-last-ingested-for-charts
branch
from
f2dd35a to
1d9aa90
Compare
MatMoore
changed the title
We were deliberately hiding this because the dbt last modified date is misleading.
MatMoore
force-pushed
the
fetch-last-ingested-for-charts
branch
from
dd611b4 to
62f68ca
Compare
MatMoore
force-pushed
the
fetch-last-ingested-for-charts
branch
from
62f68ca to
4ae4fc7
Compare
murdo-moj
reviewed
Nov 29, 2024
murdo-moj
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastIngestedwas missing from the GraphQL query for fetching charts, preventing the metadata last updated from being displayed in that case. I've also removed it from the search query as it wasn't needed.Data last updated wasn't being displayed for any entity type as it was referencing a non-existent property. This was intentional for CaDeT metadata but I've enabled it for other platforms.
#1113
Before
After