Fmd 1081 publication details page

[hjribeiro-moj]

Add support for publication collection and publication dataset subtype:

• details.py
• • Added classes PublicationCollectionDetailsService and PublicationDatasetDetailsService
• • Minor refactor pulling defining template away from views
• search.py
• • Allow search by subtype
• removed elif blocks throughout the code replacing them with mappings
• datahub_client:
• • Added 2 methods to get PublicationCollectionDetails and PublicationDataseDetails
• extended graphql queries to return externalURL used on both new services
• Added New classes for types and subtype to avoid magic strings

[hjribeiro-moj]

Need to fix tag on pub_dataset:

[hjribeiro-moj]

publication collections:

[murdo-moj]

A more general note on refactoring stuff we'd still to do after we finished yesterday:

• Align the details services with the datahub entity types and subtypes (eg Class for the parent entity type of DatasetDetailsService, subclass it for the subtype details services eg TableDetailsService)
• Finalise designs for the new publications details pages (where to link to gov.uk)
• Check the filters are working as expected with subtypes (eg searching for tables returns publication datasets currently) (created bug)
• Mat M suggested on another PR to split the entity parse methods into parser classes. Seems like a nice idea.
• Add some selenium tests for the new details pages? (new ticket)

[murdo-moj]

🚀

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ AttributeError: 'FindMoJDataEntityType' object has no attribute 'datahub_type' /search View Issue
• ‼️ ValidationError: 1 validation error for EntitySummary /details/{result_type}/{urn} View Issue

_{Did you find this useful? React with a 👍 or 👎}