Add environment to the ingress name #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdawson1982
had a problem deploying
to
dev
GitHub Actions
Failure
mitchdawson1982
had a problem deploying
to
dev
GitHub Actions
Failure
mitchdawson1982
force-pushed
the
name-ingress-per-environment
branch
from
6ccabdd to
ff11ad9
Compare
MatMoore
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr creates a unique ingress based on the respective environment. This is necessary to distinguish between environments when creating dashboards or troubleshooting. It will be necessary to delete the existing ingress prior to deployment for example.
kubectl delete ingress find-moj-data-ingress-test -n data-platform-find-moj-data-testkubectl delete ingress find-moj-data-ingress-preprod -n data-platform-find-moj-data-preprodkubectl delete ingress find-moj-data-ingress-prod -n data-platform-find-moj-data-prodIt also resolves the following deployment warning
Warning: would violate PodSecurity "restricted:latest": unrestricted capabilities (container "find-moj-data" must set securityContext.capabilities.drop=["ALL"])