fix: hide data last updated for CaDeT

We were deliberately hiding this because the dbt last modified date is misleading.
ministryofjustice · Nov 29, 2024 · cbcabea · cbcabea
1 parent 42615b2
commit cbcabea
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/home/service/details.py b/home/service/details.py
@@ -7,6 +7,7 @@
 from django.core.validators import URLValidator
 from django.utils.translation import gettext as _
 
+from ..urns import PlatformUrns
 from .base import GenericService
 
 
@@ -79,6 +80,7 @@ def _get_context(self):
             "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.database_metadata.custom_properties.access_information.dc_access_requirements
             ),
+            "PlatformUrns": PlatformUrns,
         }
 
         return context
@@ -119,6 +121,7 @@ def _get_context(self):
             "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.table_metadata.custom_properties.access_information.dc_access_requirements
             ),
+            "PlatformUrns": PlatformUrns,
         }
 
     def _get_template(self):
@@ -162,6 +165,7 @@ def _get_context(self):
             "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.chart_metadata.custom_properties.access_information.dc_access_requirements
             ),
+            "PlatformUrns": PlatformUrns,
         }
 
 
@@ -188,4 +192,5 @@ def _get_context(self):
             "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.dashboard_metadata.custom_properties.access_information.dc_access_requirements
             ),
+            "PlatformUrns": PlatformUrns,
         }
diff --git a/home/urns.py b/home/urns.py
@@ -0,0 +1,3 @@
+class PlatformUrns:
+    CADET = "dbt"
+    PLATFORM_URNS = "performance-hub"
diff --git a/templates/details_base.html b/templates/details_base.html
@@ -64,7 +64,7 @@ <h2 class="govuk-heading-s govuk-!-margin-top-3">
                 {{entity.created | date:"jS F Y"}} ({{entity.created|naturaltime}})
               </li>
             {% endif %}
-            {% if entity.data_last_modified %}
+            {% if entity.data_last_modified and entity.platform.urn != PlatformUrns.CADET %}
               <li>
                 <span class="govuk-!-font-weight-bold">{% translate "Last updated:" %}</span>
                 {{entity.data_last_modified | date:"jS F Y"}}

diff --git a/templates/details_metric.html b/templates/details_metric.html
@@ -1,7 +1,7 @@
 {% extends "details_base.html" %}
 
 {% block extra_description %}
-{% if entity.platform.urn == 'performance-hub' %}
+{% if entity.platform.urn == PlatformUrns.PERFORMANCE_HUB %}
 <p>Data quality: the data is checked to be good enough to support the outcomes it is being used for. Data values
   should be right, but there are other factors that help ensure data meets the needs of its users.</p>
 <p>Please remember that this data is for INTERNAL USE ONLY and not to be shared outside the organisation.</p>

diff --git a/templates/partial/contact_info.html b/templates/partial/contact_info.html
@@ -58,7 +58,7 @@ <h2 class="govuk-heading-s govuk-!-margin-bottom-1">{% translate "Data custodian
   <p id="data_owner" class="govuk-body">
     {% if governance.data_owner.email %}
       {{ governance.data_owner.email|urlize }}
-    {% elif platform.urn == 'performance-hub' %}
+    {% elif platform.urn == PlatformUrns.PERFORMANCE_HUB %}
       No owner is listed as this data is undergoing a review of ownership.
     {% else %}
       {% blocktranslate %}Not provided - <a href="https://moj.enterprise.slack.com/archives/C06NPM2200N" class="govuk-link" rel="noreferrer noopener" target="_blank">contact the Data Catalogue team</a> about this data.{% endblocktranslate %}