-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: Select Component #2762
Draft
sdaoud
wants to merge
18
commits into
ministryofjustice:main
Choose a base branch
from
cabinetoffice:for-steve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
draft: Select Component #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project already uses NVM, doesn't hurt to add the config to make the node version switching work automagically
The documentation drift fix
Using the straight `docker-compose up` doesn't quite spin up the services correctly. The use of `make setup` is the correct first step, where every subsequent `docker-compose up` will work correctly.
This class was used to parse the payload returned by the Auth0 identity provider. Since the switch over to Cabinet Offices' provider, the payload returned is different, hence this change.
It looks like the app used Azure & Google to allow the users to auth against. I'm not aware that this will be used going forward, so I'm removing these tests.
Auth0 was OAuth2 provider for Ministry of Justrice. AWS Cognito is being used by Cabinet Office, in particular the app named Cola. This change removes the library, flow and configuration for Auth0 setup and moves it over to Cola.
Adding in order to whitelist the holders of csc.gov.uk emails to be able to log in
It's more configurable this way
Because the value `\n` was escaped as `\\n`, so it would break the usage for JWT. This is probably because the env var is kept in AWS Secrets Manager, then read from there and populated as an env var within the Kubernetes deployment env var.
Using the set name, which will match the pod name and the namespace name in Kubernetes
It's no longer `docker-compose`, but `docker compose` (two words).
It needs to stay `editor` for now, otherwise the auth flow breaks.
Otherwise it's a WIP and a mess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.