✨ Add a register domains script with a test #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This existed in a previous iteration of the repository. I've rewritten the script in Python to ensure it fits with ops eng tooling preference.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
| def get_registrant_contact(): | ||
| return { | ||
| "FirstName": "Steve", | ||
| "LastName": "Marshall", |
There was a problem hiding this comment.
This probably shouldn’t be me anymore. We should probably register it as the organisation if possible, but the AWS API didn’t support that when I wrote the original script. If that’s still not possible, I’d say make first name Ministry and last name of Justice or something?
There was a problem hiding this comment.
It might also be worth seeing if the registrant contact is set to me for all the other domains in AWS, too, and changing those if we can?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This existed in a previous iteration of the repository. I've rewritten the script in Python to ensure it fits with ops eng tooling preference.