Skip to content

Commit

Permalink
💚 Fix broken output from makefile
Browse files Browse the repository at this point in the history
This commit removes the makefile calls in the pipeline as we need to utilise stdout.
  • Loading branch information
jasonBirchall committed Jun 27, 2024
1 parent 893b0cd commit 2068eae
Showing 1 changed file with 3 additions and 18 deletions.
21 changes: 3 additions & 18 deletions .github/workflows/check-unmanaged-zones.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,15 @@ jobs:

- name: Install dependencies
run: |
make install
python -m pip install -r requirements.txt
- name: Run check for unmanaged zones
id: check-zones
env:
AWS_ACCESS_KEY_ID: ${{ secrets.OCTODNS_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.OCTODNS_AWS_SECRET_ACCESS_KEY }}
PYTHONUNBUFFERED: 1
run: |
echo "Running check for unmanaged zones..."
output=$(make check-unmanaged-zones 2>&1)
echo "$output"
echo "check_output<<EOF" >> $GITHUB_OUTPUT
echo "$output" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
if echo "$output" | grep -q "not managed by octoDNS"; then
echo "unmanaged_zones_found=true" >> $GITHUB_OUTPUT
else
echo "unmanaged_zones_found=false" >> $GITHUB_OUTPUT
fi
# Exit with non-zero status if unmanaged zones are found
if echo "$output" | grep -q "not managed by octoDNS"; then
exit 1
fi
run: python check_unmanaged_zones.py

- name: Send notification to Slack
uses: slackapi/slack-github-action@e28cf165c92ffef168d23c5c9000cffc8a25e117 #v1.24.0
Expand Down Expand Up @@ -96,4 +81,4 @@ jobs:
}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK

0 comments on commit 2068eae

Please sign in to comment.