Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables stateful ingestion in the custom ingestion source we've written for justice-data.
This means it will soft-delete entities that are not in the data for ingestion in any latest run when compared to the previous run.
We currently delete all justice-data before each ingestion but this is a better approach.
datahub guidance: https://datahubproject.io/docs/metadata-ingestion/docs/dev_guides/add_stateful_ingestion_to_source/
I tested this by not excluding any ids and then reingesting and then adding the exclusions back in for another ingestion, this is logged by the source report (and the entities are removed from datahub)
We should look to implement the same across our other custom ingestion sources.