Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 temp skip for opensearch logging tests, message tweaks #3255

Merged
merged 2 commits into from
Jul 29, 2024
Merged

chore: 🤖 temp skip for opensearch logging tests, message tweaks #3255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d19fbc
chore: 🤖 temp skip for opensearch logging tests, message tweaks
sj-williams Jul 29, 2024
701362a
chore: 🤖 unset focus test
sj-williams Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ var _ = Describe("logging", Serial, func() {
Expect(err).ToNot(HaveOccurred())
})

It("should be able to retrieve the log message", func() {
It("should be able to retrieve the log message from elasticsearch", func() {
var podName string

// To get the pod name, we need to first get all pods in the namespace.
Expand Down
4 changes: 2 additions & 2 deletions test/modsec_logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ var _ = Describe("logging", Ordered, Serial, func() {
})

Describe("check modsec logs have not been dropped", Ordered, func() {
It("should be able to retrieve the log messages", func() {
It("should be able to retrieve the log messages from modsec opensearch", func() {
values := helpers.SearchData{
Query: helpers.BoolData{
Bool: helpers.MustFilterData{
Expand All @@ -137,7 +137,7 @@ var _ = Describe("logging", Ordered, Serial, func() {
helpers.GetSearchResults(values, search, awsSigner, client)
})

It("should be able to retrieve the audit log messages", func() {
It("should be able to retrieve the audit log messages from modsec opensearch", func() {
auditValues := helpers.SearchData{
Query: helpers.BoolData{
Bool: helpers.MustFilterData{
Expand Down
5 changes: 3 additions & 2 deletions test/user_app_logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (

// Logging tests define the ability for Cloud Platform to perform aggregated logging
// on the platform. The tests are designed to be run in a Kubernetes cluster, with a logging agent installed.
var _ = Describe("logging", Ordered, func() {
var _ = FDescribe("logging", Ordered, func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to get rid of the F here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

Context("when an app generates a log message", func() {
var (
namespace string
Expand Down Expand Up @@ -121,7 +121,8 @@ var _ = Describe("logging", Ordered, func() {
})

Describe("check app logs have not been dropped", Ordered, func() {
It("should be able to retrieve the log messages", func() {
It("should be able to retrieve the log messages from opensearch", func() {
Skip("Skipping this test whilst OpenSearch logging is temporarily disabled")
values := helpers.SearchData{
Query: helpers.BoolData{
Bool: helpers.MustFilterData{
Expand Down